Fix: stale ec2 credentials would be used - #1052
Merged
Merged
Conversation
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
garloff
reviewed
Jan 20, 2026
garloff
left a comment
garloff
left a comment
Member
There was a problem hiding this comment.
This should work and is probably the minimal change.
But wouldn't it be cleaner to change ensure_ec2_credentials() to just unconditionally create an ec2 cred and return it?
Contributor
Author
|
@garloff It's what I had time for today. |
garloff
approved these changes
Jan 20, 2026
garloff
left a comment
garloff
left a comment
Member
There was a problem hiding this comment.
Let's go with it, we can always simplify later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.